Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: peak picking returns id and keep id if it exists #108

Merged
merged 21 commits into from
Aug 27, 2022
Merged

feat: peak picking returns id and keep id if it exists #108

merged 21 commits into from
Aug 27, 2022

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Aug 23, 2022

No description provided.

@jobo322 jobo322 linked an issue Aug 23, 2022 that may be closed by this pull request
peak picking returns id and keep id if it exists #107
Closed
@codecov
Copy link

codecov bot commented Aug 23, 2022 •
edited
Loading

Codecov Report

Merging #108 (1ecf11a) into master (928ea11) will decrease coverage by 1.09%.
The diff coverage is 87.69%.

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   95.28%   94.19%   -1.10%     
==========================================
  Files           9       10       +1     
  Lines         276      310      +34     
  Branches      108      118      +10     
==========================================
+ Hits          263      292      +29     
- Misses         13       18       +5
Impacted Files Coverage Δ
src/post/optimizePeaksWithLogs.ts 91.66% <66.66%> (ø)
src/utils/addMissingIDs.ts 75.00% <75.00%> (ø)
src/post/joinBroadPeaks.ts 87.03% <85.00%> (+0.08%) ⬆️
src/post/broadenPeaks.ts 93.33% <89.47%> (-6.67%) ⬇️
src/gsd.ts 97.00% <100.00%> (ø)
src/post/optimizePeaks.ts 100.00% <100.00%> (ø)
src/utils/addMissingShape.ts 100.00% <100.00%> (ø)
src/utils/setShape.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lpatiny
lpatiny reviewed Aug 23, 2022
View reviewed changes
src/GSDBroadenPeak.ts
x: number;
y: number;
width: number;
shape?: Shape1D;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really know the shape ? I think I didn't put it because it was not really defined.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BroadenPeak increases the width of the peak by a factor, the input is a GSDPeak structure but the property shape was added, that is why I added shape as optional in GSDBroadenPeak

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

jobo322 added 19 commits August 24, 2022 11:25
@jobo322
chore: initial steps to keep id property
10d0495
@jobo322
feat(broadenPeaks): conditional type
4843af3
@jobo322
chore(joinBroadPeaks): conditional type
02ee40a
@jobo322
feat(setShape): generic function n output option
7484afd 
pure function now
@jobo322
chore(gsd): returns id as required
18a9dd2
@jobo322
chore: remove aditionals types
fa73b36
@jobo322
chore: refactor broadenPeaks
08a888b
@jobo322
chore(joinBroadPeaks): refactor
ff5d2f0
@jobo322
chore: fix eslint
e2c3a75
@jobo322
chore(joinBroadPeaks): remove conditional type
7ca00e5
@jobo322
chore: don't add id in gsd
a88251b
@jobo322
chore(optimizePeaks): conditional types
38765d0
@jobo322
chore: gsd returns id n test cases fixed
99c2a94
@jobo322
fix(addMissingShape): convert to pure
2514b5f
@jobo322
fix(gsd): assert result to GSDPeakID[]
96c0cff
@jobo322
fix(joinBroadPeaks): returns width ids
443cd16
@jobo322
fix(optimizePeaks): convert to generic n conditional types
c68e8de
@jobo322
feat: addMissingIDs
6799f90
@jobo322
fix: prettier
7321cd5
@jobo322 jobo322 force-pushed the 107-peak-picking-returns-id-and-keep-id-if-it-exists branch from 31d56fb to 7321cd5 Compare August 24, 2022 16:25
@mljs-bot
Copy link
Contributor

Published prerelease version 12.0.0-pre.1661358412 to npm.

To install it, run:

npm install ml-gsd@12.0.0-pre.1661358412

@mljs-bot
Copy link
Contributor

Published prerelease version 12.0.0-pre.1661365726 to npm.

To install it, run:

npm install ml-gsd@12.0.0-pre.1661365726

@mljs-bot
Copy link
Contributor

Published prerelease version 12.0.0-pre.1661543950 to npm.

To install it, run:

npm install ml-gsd@12.0.0-pre.1661543950

@jobo322 jobo322 merged commit f22f5a5 into master Aug 27, 2022
@jobo322 jobo322 deleted the 107-peak-picking-returns-id-and-keep-id-if-it-exists branch August 27, 2022 04:55
@mljs-bot mljs-bot mentioned this pull request Aug 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpatiny lpatiny lpatiny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

peak picking returns id and keep id if it exists
3 participants
@jobo322 @mljs-bot @lpatiny